Return Constraint Compilation Errors #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetzrrGit
changed the title
goetzrrGit
force-pushed
the
aerie-1117--Return_compilation_errors
branch
from
5841777 to
9b80ee1
Compare
goetzrrGit
had a problem deploying
to
test-workflow
GitHub Actions
Failure
goetzrrGit
force-pushed
the
aerie-1117--Return_compilation_errors
branch
from
9b80ee1 to
0209d71
Compare
goetzrrGit
had a problem deploying
to
test-workflow
GitHub Actions
Failure
goetzrrGit
force-pushed
the
aerie-1117--Return_compilation_errors
branch
from
0209d71 to
be3b95a
Compare
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
goetzrrGit
force-pushed
the
aerie-1117--Return_compilation_errors
branch
from
be3b95a to
3e52246
Compare
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
reviewed
Nov 7, 2023
goetzrrGit
force-pushed
the
aerie-1117--Return_compilation_errors
branch
from
3e52246 to
853ba6d
Compare
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
goetzrrGit
force-pushed
the
aerie-1117--Return_compilation_errors
branch
from
853ba6d to
f23d2da
Compare
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
…ompilation errors.
goetzrrGit
force-pushed
the
aerie-1117--Return_compilation_errors
branch
from
f23d2da to
2c30531
Compare
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
This will return an object containing all constraints processed by the server, including whether they have compilation errors or ran successfully.
goetzrrGit
force-pushed
the
aerie-1117--Return_compilation_errors
branch
from
2c30531 to
f388c79
Compare
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Update GQL to match what the server will return for constraints and compilation errors. * Update the UI to parse the ConstraintViolation response differently. This will return an object containing all constraints processed by the server, including whether they have compilation errors or ran successfully.
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Update GQL to match what the server will return for constraints and compilation errors. * Update the UI to parse the ConstraintViolation response differently. This will return an object containing all constraints processed by the server, including whether they have compilation errors or ran successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a constraint compilation error occurs, the server swallows it, making it difficult for users to develop constraints in Aerie. This is because users cannot see why the constraint is not running or where the error is located.
This PR changes this behavior and will display compilation errors in the UI console. This will allow users to quickly identify and fix compilation errors, improving their constraint development experience.
Additionally, this PR updates the gql call to support receiving errors or results per constraint. This will be used in a future PR to stop the Merlin server from short-circuiting and not running the full list of constraints.