Always display select/unselect all buttons on layer filters #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffpamer
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #592 #591
This PR makes it so that when selecting filter options to be included in a timeline row, we make a "select all" and "unselect all" option always visible, regardless of whether filter text has been supplied.
We originally specified to move these buttons to the top of the filter list, and stack them side-by-side. But depending on the length of the resource names, we don't necessarily have much width to work with and the side-by-side approach seemed like it could be cramped. As @joswig pointed out in a comment on #592, another option here is to keep the buttons at the bottom, but just make them fixed so they're always visible. I do think this works a bit better in this context and doesn't steal too much vertical space from the list items themselves. Happy to discuss if anyone disagrees or thinks there's a better approach here?