1051 backend model changes on cosmos to hold new incoming urls #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new-incoming-urls Merging dev into this branch
Closed
for more information, see https://pre-commit.ci
CarsonDavis
reviewed
Nov 4, 2024
| dump_urls = DumpUrl.objects.filter(collection=collection) | ||
| curated_urls = CuratedUrl.objects.filter(collection=collection) | ||
|
|
||
| DeltaUrl.objects.filter(collection=collection).delete() |
There was a problem hiding this comment.
might want this to happen at the end?
CarsonDavis
reviewed
Nov 4, 2024
| delete=False, | ||
| ) | ||
| elif ( | ||
| curated_url.scraped_title != dump_url.scraped_title |
There was a problem hiding this comment.
we might need to only write the different metadata, not all of it
CarsonDavis
reviewed
Nov 4, 2024
sde_collections/tasks.py
Outdated
| ) | ||
|
|
||
|
|
||
| def populate_dump_urls(collection): |
There was a problem hiding this comment.
might move this up in the file?
CarsonDavis
reviewed
Nov 4, 2024
sde_collections/tasks.py
Outdated
|
|
||
|
|
||
| def populate_dump_urls(collection): | ||
| urls = Url.objects.filter(collection=collection) |
There was a problem hiding this comment.
this is an abstract model, it should have nothing stored in it
CarsonDavis
reviewed
Nov 4, 2024
| @@ -49,7 +52,7 @@ def _get_data_to_import(collection, server_name): | |||
| continue | |||
|
|
|||
| augmented_data = { | |||
| "model": "sde_collections.candidateurl", | |||
| "model": "sde_collections.url", | |||
There was a problem hiding this comment.
bishwas tried to make this dump directly into dump url, but that didn't work. need to troubleshoot.
…ng-urls' of github.com:NASA-IMPACT/COSMOS into 1051-backend-model-changes-on-cosmos-to-hold-new-incoming-urls
for more information, see https://pre-commit.ci
…ng-urls' of github.com:NASA-IMPACT/COSMOS into 1051-backend-model-changes-on-cosmos-to-hold-new-incoming-urls
for more information, see https://pre-commit.ci
CarsonDavis
reviewed
Nov 11, 2024
| "candidate-urls-api/<str:config_folder>/", | ||
| view=views.CandidateURLAPIView.as_view(), | ||
| name="candidate-url-api", | ||
| "curated-urls-api/<str:config_folder>/", |
There was a problem hiding this comment.
we need to keep the old one and add a new one alongside
CarsonDavis
reviewed
Nov 11, 2024
| @@ -307,8 +308,8 @@ def create(self, request, *args, **kwargs): | |||
| return Response(serializer.data, status=status.HTTP_201_CREATED) | |||
|
|
|||
|
|
|||
| class CandidateURLAPIView(ListAPIView): | |||
| serializer_class = CandidateURLAPISerializer | |||
| class CuratedURLAPIView(ListAPIView): | |||
There was a problem hiding this comment.
keep the old one and add a new one alongside
…new-incoming-urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.