Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): requester pays config in validation #388

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

anayeaye
Copy link
Collaborator

@anayeaye anayeaye commented Jun 3, 2024

Issue

NASA-IMPACT/veda-data#134

What?

  • Add optional requester pays configuration to ingest API to validate accessibility of assets in buckets that require requester pays if the titiler been configured to use requester pays

Why?

  • Ingest API verifies that all hrefs in new items are accessible to the titiler but is failing in cases where the bucket requires requester pays configuration

Testing?

I deployed this manually to dev and confirmed that the change resolves the unable to access objects errors when configured to use requester pays.

@anayeaye anayeaye marked this pull request as ready for review June 3, 2024 22:37
@@ -26,7 +26,6 @@ def validated_token(
required_scopes: security.SecurityScopes,
) -> Dict:
# Parse & validate token
logger.info(f"\nToken String {token_str}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@anayeaye anayeaye merged commit 081537e into develop Jun 4, 2024
4 checks passed
@anayeaye anayeaye deleted the fix/requester-pays-config-in-validation branch June 4, 2024 16:51
botanical added a commit that referenced this pull request Jun 10, 2024
…extra fields in collection links (#390)

### Added
None

### Changed/Updated
- [chore: Add rio-tiler version in raster API #
385](#385)

### Fixed
- [fix: update stac and raster api title and description
#379](#379)
- [fix: backend monitoring changes
#371](#371)
- [fix: ingestor role to have s3 access
#387](#387)
- [fix(ingest): requester pays config in validation
#388](#388)
- [fix: allow extra fields in collection links to support extensions
#389](#389)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants