Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md to include note on git submodule 'gotcha' #144

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Update README.md to include note on git submodule 'gotcha' #144

merged 2 commits into from
Oct 16, 2024

Conversation

TeaganKing
Copy link
Collaborator

@TeaganKing TeaganKing commented Oct 15, 2024 •
edited
Loading

This is intended to be a minor PR to include some documentation in response to #137 .

  • Have you followed the guidelines in our Contributor's Guide (including the pre-commit check)?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?

@TeaganKing TeaganKing self-assigned this Oct 15, 2024
@TeaganKing TeaganKing linked an issue Oct 15, 2024 that may be closed by this pull request
Update documentation to help transition from manage_externals -> git submodules #137
Closed
mnlevy1981
mnlevy1981 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@mnlevy1981 mnlevy1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@TeaganKing TeaganKing merged commit 92b0c30 into NCAR:main Oct 16, 2024
2 checks passed
@TeaganKing TeaganKing deleted the externals_documentation branch November 21, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnlevy1981 mnlevy1981 mnlevy1981 approved these changes

Assignees

@TeaganKing TeaganKing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update documentation to help transition from manage_externals -> git submodules
2 participants
@TeaganKing @mnlevy1981