Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup PR #2 (v2) #156

Merged
merged 11 commits into from
Nov 22, 2024
Merged

Cleanup PR #2 (v2) #156

merged 11 commits into from
Nov 22, 2024

Conversation

TeaganKing
Copy link
Collaborator

@TeaganKing TeaganKing commented Nov 21, 2024

Description of changes:

This PR is intended to close #152 by splitting run into timeseries and diagnostics, renaming build to webpage, and making timeseries, diagnostics, and webpage scripts executable.

@TeaganKing TeaganKing self-assigned this Nov 21, 2024
@TeaganKing
Copy link
Collaborator Author

TeaganKing commented Nov 21, 2024

The following tools do run once pip install -e . is done from the cupid-dev environment:

  • cupid-timeseries
  • cupid-diagnostics
  • cupid-webpage

Additionally, these scripts can now be run from an examples directory (eg, key_metrics), as follows:

  • ../../cupid/run_timeseries.py
  • ../../cupid/run_diagnostics.py
  • ../../cupid/cupid_webpage.py

A few outstanding items to address:

  • We may want to implement the option to control which components timeseries are run with click.
  • Note that ROF timeseries is not currently implemented.

@TeaganKing TeaganKing linked an issue Nov 21, 2024 that may be closed by this pull request
cupid/timeseries.py Outdated Show resolved Hide resolved
@TeaganKing TeaganKing marked this pull request as ready for review November 22, 2024 19:55
Copy link
Collaborator

@mnlevy1981 mnlevy1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! One small fix, but otherwise it's ready to go

@@ -111,7 +111,7 @@ compute_notebooks:

atm:
link_to_ADF:
kernel_name: cupid-dev
kernel_name: cupid-analysis
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link_to_ADF used cupid-dev because it needs to import IPython to inline plots and create links... so this should be cupid-infrastructure rather than cupid-analysis

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noting this! I just made that change.

Copy link
Collaborator

@mnlevy1981 mnlevy1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mnlevy1981 mnlevy1981 merged commit ee4ac42 into NCAR:main Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming efforts A few renaming suggestions
2 participants