-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Test optimal kerchunk #186
Open
valeriupredoi
wants to merge
63
commits into
main
Choose a base branch
from
test_optimal_kerchunk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OK new Kerchunk=0.2.4 works very well, and I also fixed the dreaded SegFault that was plaguing us until today 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a sandbox testing a slightly modded Kercunk that kerchunks inly a desired
Dataset
- the good folk at Kerchunk are already investigating means of implementing such an option in Kerchunk in fsspec/kerchunk#424 - and some timing test results can be seen in fsspec/kerchunk#424 (comment) (after one setsdefault_cache_type
tofirst
as Martin recommended)Label: needs new Kerchunk
Update as of February 29
With the Kerchunk PR now merged fsspec/kerchunk#424 and the issues related to the newer Kerchunk functionality now ironed out, this is ready for a merge when kerchunk release the new version that contains that PR. Test results are very promising:
So all the time spent in PyActiveStorage is sub-1s! This is for the
tests/test_compression_remote_reductionist.py::test_compression_and_filters_cmip6_forced_s3_from_local_bigger_file_v1
test.