Add firedrake-complex to test suite #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDBetteridge
force-pushed
the
JDBetteridge/complex_docker
branch
from
dc66fc1
to
658f31c
Compare
|
❤️ would this close #17? |
|
Not entirely, my understanding (from a Firedrake point of view) is that ngsPETSc shouldn't really care about whether PETSc is in real or complex mode since we only really support real mesh coordinates. My solution in PR51 was to just cast the coordinates to real. I think this is a legitimate solution strategy. I could take a look into it, but I'm not an ngsPETSc expert 😅 That being said there would be no issues running the ngsPETSc tests in this new CI step once things are fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin