Actually set path in cookie

NHAS · Jun 10, 2024 · 7a96475 · 7a96475
1 parent 1b017da
commit 7a96475
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 14 deletions.
diff --git a/internal/webserver/authenticators/init.go b/internal/webserver/authenticators/init.go
@@ -51,17 +51,17 @@ func (e *enable) Enable() {
 	*e = true
 }
 
-func IssueChallengeTokenCookie(w http.ResponseWriter, r *http.Request, challenge string) error {
+func IssueChallengeTokenCookie(w http.ResponseWriter, r *http.Request, challenge string) {
 
 	cookie := http.Cookie{
 		Name:     "challenge",
 		Value:    challenge,
 		Expires:  time.Now().Add(8 * time.Hour),
-		SameSite: http.SameSiteNoneMode,
-		Secure:   r.URL.Scheme == "https",
+		SameSite: http.SameSiteLaxMode,
+		Secure:   true,
 		HttpOnly: false,
+		Path:     "/",
 	}
 	http.SetCookie(w, &cookie)
 
-	return nil
 }
diff --git a/internal/webserver/resources/static/js/challenge.js b/internal/webserver/resources/static/js/challenge.js
@@ -4,11 +4,12 @@ const url = (httpsEnabled ? 'wss://' : 'ws://') + window.location.host + "/chall
 
 let backoff = 200;
 let challenge = localStorage.getItem("challenge");
-if (challenge === null) {
+if (challenge === null || challenge === "null") {
     // oidc sets the challenge via cookie
     challenge = getCookie("challenge");
-    localStorage.setItem("challenge", challenge)
-
+    if(challenge !== null) {
+        localStorage.setItem("challenge", challenge)
+    }
     deleteCookie("challenge")
 }
 

diff --git a/internal/webserver/resources/static/js/pam.js b/internal/webserver/resources/static/js/pam.js
@@ -72,9 +72,9 @@ async function loginUser(location) {
             document.getElementById("error").hidden = false;
             return
         }
-
-        localStorage.setItem("challenge", send.headers.get("WAG-CHALLENGE"))
-
+        if (send.headers.get("WAG-CHALLENGE") !== null) {
+            localStorage.setItem("challenge", send.headers.get("WAG-CHALLENGE"))
+        }
     } catch (e) {
         console.log("logging in user failed")
         document.getElementById("errorMsg").textContent = e.message;

diff --git a/internal/webserver/resources/static/js/totp.js b/internal/webserver/resources/static/js/totp.js
@@ -80,8 +80,11 @@ async function loginUser(location) {
             return
         }
 
-        localStorage.setItem("challenge", send.headers.get("WAG-CHALLENGE"))
-
+
+        if (send.headers.get("WAG-CHALLENGE") !== null) {
+            localStorage.setItem("challenge", send.headers.get("WAG-CHALLENGE"))
+        }
+
     } catch (e) {
         console.log("logging in user failed")
         document.getElementById("errorMsg").textContent = e.message;

diff --git a/internal/webserver/resources/static/js/webauthn.js b/internal/webserver/resources/static/js/webauthn.js
@@ -213,8 +213,10 @@ async function loginUser(event) {
 
             return
         }
-
-        localStorage.setItem("challenge", send.headers.get("WAG-CHALLENGE"))
+
+        if (send.headers.get("WAG-CHALLENGE") !== null) {
+            localStorage.setItem("challenge", send.headers.get("WAG-CHALLENGE"))
+        }
 
     } catch (e) {
         console.log("logging in failed: ", e)