Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial thoughts on statements around data processing principles #180

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

walteck
Copy link
Contributor

@walteck walteck commented Sep 29, 2021

Would appreciate some additional input / discussion here to ensure an appropriate statement of how teams should be operating.
@andyblundell and @iw-ezequiel - any thoughts?

@walteck walteck requested a review from a team September 29, 2021 08:50
Copy link
Contributor

@iw-ezequiel iw-ezequiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Chris, thanks for picking this up. I think this point is very relevant - what I'm wondering is how we generally go about these principles, do we have the right list and are they at the right level. I took a stab at rationalising some of the points in #158 but that's still work in progress. Might be worth a separate discussion? (or maybe I'm overthinking this, that's very possible too!)

@andyblundell
Copy link
Contributor

Hi @walteck defo agree this is a really good thing to include. I think the section on secrets mentions data too, so there might be some joining up to do - and I think there is a vague reference to tools like Macie which could potentially be used to find bad things after the event (obviously not as good as not having the problem in the first place)

Copy link
Contributor

@andyblundell andyblundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we relocate the new section to everything-as-code, to sit alongside the guidance around code hygiene etc, and we include the high-level principle in section 2 (build quality in) rather than as a new section 8 (to stick with the 7 lean chapters).

"Protect code quality to keep code easy to maintain." could be changed with "and separate code from data" maybe - or there could be a line of its own in section 2?

Happy to discuss obviously :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants