Failing link check #310
Failing link check #310
Conversation
regularfry
changed the base branch from
chwa1-ignore-link-checking-azure-lniks
to
main
|
Setting "ready for review" to get the markdown link checker action to run. Don't worry about reviewing. |
This increases the timeout from a default 10s to 30s, in case we're getting throttled on azure links
|
Kudos, SonarCloud Quality Gate passed!
|
|
Ok, so this has passed. Looking through the dependency stack I couldn't see anything obviously wrong about the way timeouts are handled, but replacing redirected links with their eventual destination means fewer network requests, so fewer opportunities to go wrong. The increased timeout also means that if we are getting rate-limited at the other end, we're less likely to see a failure as a result. |
regularfry
changed the base branch from
main
to
chwa1-ignore-link-checking-azure-lniks
|
Ah is there a timeout setting on this action - it does throw a few false negatives, which are a nuisance |
Yeah, I've changed it to 30 seconds. It defaults to 10. I'm unclear what would fail at 10 seconds but pass at 30. It just doesn't seem like a very natural breakpoint unless we're getting rate limited somewhere. |
|
Just a sanity check to see what the behaviour of the link checker is around redirects.