fix(navbar): onchange issue

style: version update
NJUPT-SAST · Aug 24, 2024 · d7de4bc · d7de4bc
1 parent a29e104
commit d7de4bc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/ui-react/lib/Navbar/Navbar.tsx b/packages/ui-react/lib/Navbar/Navbar.tsx
@@ -78,8 +78,7 @@ export const Navbar = React.forwardRef<HTMLDivElement, NavbarProps>(
 
     useEffect(() => {
       itemMoveAnimation();
-      onchange && onchange(selectItem);
-    }, [selectItem, onchange]);
+    }, [selectItem]);
 
     const itemMoveAnimation = () => {
       const currentEle = selectedItemRef.current as HTMLDivElement;
@@ -115,7 +114,10 @@ export const Navbar = React.forwardRef<HTMLDivElement, NavbarProps>(
                     className={`${styles['navbar-item']} ${selectItem === item.itemKey ? styles['select'] : ''}`}
                     id={item.itemKey}
                     ref={selectItem === item.itemKey ? selectedItemRef : undefined}
-                    onClick={() => setSelectItem(item.itemKey)}
+                    onClick={() => {
+                      setSelectItem(item.itemKey);
+                      onchange && onchange(item.itemKey);
+                    }}
                   >
                     {item.icon}
                     <span>{item.text}</span>

diff --git a/packages/ui-react/package.json b/packages/ui-react/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ui-aurora/react",
-  "version": "0.0.14",
+  "version": "0.0.16",
   "description": "A React UI library built for SASTOJ",
   "author": "sast",
   "license": "MIT",