-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregate command sets #1087
Merged
Merged
Aggregate command sets #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximon18
reviewed
Jul 4, 2023
ximon18
reviewed
Jul 4, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
reviewed
Jul 5, 2023
ximon18
approved these changes
Jul 5, 2023
LGTM, only very minor feedback. I like the refinements to the upgrade process. I have NOT run the test suite or tried to run Krill to verify these changes, but based on your description of the intent and approach and my subsequent reading of the changes I didn't find anything worth blocking this PR. Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1078