Skip to content

Commit

Permalink
NMreadExt introduced
Browse files Browse the repository at this point in the history
  • Loading branch information
philipdelff committed Oct 12, 2023
1 parent 55cb1f8 commit f1590d3
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 6 deletions.
5 changes: 5 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# 0.1.2
## New features
* NMreadExt is a new function that reads parameter estimates,
uncertainties if available, estimation iterations and other
information from .ext files.

## Other improvements
* NMreadCsv supports multiple prioritized formats in the `format`
arguments.
Expand Down
1 change: 1 addition & 0 deletions R/NMscanData.R
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ NMscanData <- function(file, col.row, use.input, merge.by.row,
if(missing(check.time)) check.time <- NULL
if(missing(tz.lst)) tz.lst <- NULL
if(missing(as.fun)) as.fun <- NULL
### why is this not needed?
## if(missing(modelname)) modelname <- NULL
if(missing(quiet)) quiet <- NULL
if(missing(formats.read)) formats.read <- NULL
Expand Down
6 changes: 0 additions & 6 deletions R/addTAPD.R
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,6 @@ addTAPD <- function(data,col.time="TIME",col.evid="EVID",col.amt="AMT",col.tpdos

### Section end: Dummy variables, only not to get NOTE's in pacakge checks

## if(!missing(col.ndoses)){
## if(col.doscumn!="DOSCUMN"){
## stop("col.ndoses is deprecated. Use col.doscumn instead.")
## }
## warning("col.ndoses is deprecated. Use col.doscumn instead.")
## }
args <- getArgs()
deprecatedArg("col.ndoses","col.doscumn",args=args)

Expand Down
3 changes: 3 additions & 0 deletions devel/todo.org
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ if(any(nmdat[,sapply(.SD,function(x)any(grepl(",",x))),.SDcols=cnames.fac])) sto
Export to parent. Not sure check allows though...
** Function improvements
*** addTAPD
**** TODO [#A] Add subset.data arg like in flags functions
**** DONE Rename NDOSES to DOSCUMN
It aligns with DOSCUMA and it is clearer from DOSCUMN that its
cumulative number of doses.
Expand Down Expand Up @@ -119,6 +120,8 @@ pdosamt, doscuma
**** Bad name, what could we call it?
*** cc - create character vector function
*** NMgenText
**** TODO Test variables given in until arg exist
Or only use those that do exist. Right now a strange error is returned
**** TODO Handle until values not matching column names
**** DONE Add a until argument to specify the last column to use in nonmem
**** TODO [#B] checks: duplicate column names
Expand Down

0 comments on commit f1590d3

Please sign in to comment.