Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NMreadExt was incorrectly calculating blocksize for OMEGAs, I proposed a fix #50

Merged
merged 2 commits into from
Dec 3, 2024
Merged

NMreadExt was incorrectly calculating blocksize for OMEGAs, I proposed a fix #50

merged 2 commits into from
Dec 3, 2024

Conversation

bmreilly
Copy link
Contributor

@bmreilly bmreilly commented Dec 3, 2024

When Blocksize was >2, NMreadExt was incorrectly calculating blocksize for OMEGAS/SIGMAS blocks

philipdelff
philipdelff requested changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@philipdelff philipdelff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! can I suggest three things?

  • call it tab.i instead of tab.blocks for clarity
  • use .N instead of length(i), again for clarity
  • change abs(value)>1e-9 to i==j | abs(value)>1e-9 to always evaluate the blocksize for diagonal elements

@bmreilly
Update NMreadExt.R
4a87c54 
Making requested updates to NMreadExt for calculating iblock and blocksize
bmreilly
bmreilly commented Dec 3, 2024
View reviewed changes
Copy link
Contributor Author

@bmreilly bmreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made suggested edits to NMreadExt to calculate iblock and blocksize

@philipdelff philipdelff merged commit 29d0c1e into NMautoverse:master Dec 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipdelff philipdelff philipdelff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmreilly @philipdelff