-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add switch for two different init_grib2 approaches for non-E arakawa grids #241
add switch for two different init_grib2 approaches for non-E arakawa grids #241
Conversation
@webisu please try out my branch at https://github.com/AlexanderRichert-NOAA/NCEPLIBS-ip/tree/arakawa_grib2_fix and see if it works. It requires changes to wgrib2: in wgrib.h, add |
@edwardhartnett this code is confirmed working by @webisu. Please review this PR and also #245, then next stop, Releaseville. |
My solution for conflicting approaches to deriving the non-E arakawa grids is to include both. wgrib2 and ncep_post (incl. NAM) agree on one definition, which is different from what's in NCEPLIBS-ip currently. With this PR, the user calls
use_ncep_post_arakawa()
(which can be called from C, defined asvoid use_ncep_post_arakawa(void)
and called asuse_ncep_post_arakawa()
) to use the wgrib2/ncep_post derivation. The default behavior is to use the current code, so any users of the current definition should be unaffected. This option is only used when gdtn=32769, and can be re-disabled withunuse_ncep_post_arakawa()
.Fixes #238