bug fixed for mraerosol #700
Conversation
|
@AnningCheng-NOAA sub-component PR ccpp-physics #109 has been merged. Can you please update the submodule pointer (ccpp-physics hash: 69c9764f3ad33ec94ecc5c45891ad9745da5c569) and revert the url change in .gitmodules? |
|
@AnningCheng-NOAA ufs-community/ccpp-physics#109 was merged. Please update the ccpp/physics submodule pointer to the latest commit on the ufs/dev branch and revert the changes to .gitmodules in preparation for merge. |
|
@AnningCheng-NOAA .gitmodules should have: |
|
@AnningCheng-NOAA Also, the ccpp-physics submodule hash isn't correct. Like @zach1221 said, it should be ccpp-physics hash: 69c9764f3ad33ec94ecc5c45891ad9745da5c569 If you cd into ccpp/physics, just checkout the latest ufs/dev branch from https://github.com/ufs-community/ccpp-physics and it should be the correct one. You keep on pulling in the main branch from the NCAR fork, which is not what the develop branch of fv3atm should be pointing to. |
|
@AnningCheng-NOAA Also, the ccpp-framework hash should be https://github.com/NCAR/ccpp-framework/tree/1b6352fb24f053b738bde72eed0ddf0b60ec7c0f. Please don't pull in the latest main since it will cause a failure in one of the RTs. |
|
Grant, I just pushed in 69c9764f3ad33ec94ecc5c45891ad9745da5c569. Is it
correct now?
…On Tue, Oct 17, 2023 at 11:37 AM Grant Firl ***@***.***> wrote:
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> Also, the
ccpp-physics submodule hash isn't correct. Like @zach1221
<https://github.com/zach1221> said, it should be ccpp-physics hash:
69c9764f3ad33ec94ecc5c45891ad9745da5c569
If you cd into ccpp/physics, just checkout the latest ufs/dev branch from
https://github.com/ufs-community/ccpp-physics and it should be the
correct one. You keep on pulling in the main branch from the NCAR fork,
which is not what the develop branch of fv3atm should be pointing to.
—
Reply to this email directly, view it on GitHub
<#700 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIPNOLY6F2MBFSYKYK3X72Q4DAVCNFSM6AAAAAA5CCJDOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRWGY3TKMBTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Yes, ccpp/physics is correct, but ccpp-framework needs to be reverted. And, is the UPP hash supposed to be updated here? I thought this was only supposed to be the small ccpp-physics change? |
|
OK, looks good now. I see that ufs-community/ufs-weather-model#1915 says that UPP is supposed to be updated in here. I think we're good now. |
|
Grant, I think upp change is minor and it is already in.
…On Tue, Oct 17, 2023 at 11:41 AM Grant Firl ***@***.***> wrote:
Yes, ccpp/physics is correct, but ccpp-framework needs to be reverted.
And, is the UPP hash supposed to be updated here? I thought this was only
supposed to be the small ccpp-physics change?
—
Reply to this email directly, view it on GitHub
<#700 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMINLIZY7NQDF4HRORHTX72RLRAVCNFSM6AAAAAA5CCJDOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRWGY4DGNJRGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thanks, @AnningCheng-NOAA and @grantfirl for the assistance. @jkbk2004 @BrianCurtis-NOAA review notifications have been sent out, please review this PR when you're able. |
|
@jkbk2004 can you merge as well, please sir? |
Description
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
A bug fixed for MERRA2 coupled Thompson microphysics. The cloud water number concentration was not passed back when calling the microphysics, resulting model crash for some hurricane cases.
Is a change of answers expected from this PR?
Yes. Baseline changed whenever mraerosol=T: merra2_thompson and atmaero_control_p8_rad_micro
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
RTs in hera
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Yes
Have the ufs-weather-model regression test been run? On what platform?
Yes. at Hera: /scratch1/NCEPDEV/global/Anning.Cheng/ufs-weather-model/tests
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs