Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline post Updates #880

Merged
merged 10 commits into from
Nov 21, 2024
Merged

Inline post Updates #880

merged 10 commits into from
Nov 21, 2024

Conversation

WenMeng-NOAA
Copy link
Contributor

Description

(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
This PR is for:

  • updating upp submodule hash from the UPP repository
  • updating inline post interface with reading some new variables required by SFS
  • passing LSM number 'landsfcmdl' from model to upp

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

  • waiting on noaa-emc/nems/pull/<pr_number>
  • waiting on noaa-emc/fv3atm/pull/<pr_number>

Requirements before merging

  • All new code in this PR is tested by at least one unit test
  • All new code in this PR includes Doxygen documentation
  • All new code in this PR does not add new compilation warnings (check CI output)

Copy link
Collaborator

@jkbk2004 jkbk2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-test ran ok on weather model side.

@BrianCurtis-NOAA
Copy link
Collaborator

Is there a UPP PR associated with this, or just bumping the hash to an already merged UPP?

@jkbk2004
Copy link
Collaborator

Is there a UPP PR associated with this, or just bumping the hash to an already merged UPP?

@BrianCurtis-NOAA UPP develop branch continues to be updated with PRs tested and merged. This PR is intended to catch up latest commit: NOAA-EMC/UPP@ce5f3b1.

@FernandoAndrade-NOAA
Copy link

Testing for 2489 has completed, please continue with the merge process, thank you.

@jkbk2004 jkbk2004 merged commit 71a4729 into NOAA-EMC:develop Nov 21, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants