Missing enkfgdas_echgres dependency for metatask eanm

[RussTreadon-NOAA]

What is wrong?

enkf.yaml.j2 lists _echgres.log as a required archive file to archive. However, metatask eanm only has a dependency on enkfgdas_epmn. Thus, enkfgdas_earc00 will fail if the enkfgdas_epmn dependency is satisfied before enkfgdas_echgres completes.

What should have happened?

enkfgdas_earc00 should not fail.

What machines are impacted?

All or N/A

What global-workflow hash are you using?

0db859e

Steps to reproduce

1. install g-w develop
2. trigger g-w CI which includes gdas and enkfgdas cycles
3. force enkfgdas_echgres to NOT run
4. let metatask enkfgdas_epmn finish
5. rocotoboot enkgdas_earc00

The enkfgdas_earc00 job will fail with a FileNotFound message. For example,

FileNotFoundError: FATAL ERROR: Required file, directory, or glob logs/2021122018/enkfgdas_echgres.log not found!
+ JGDAS_ENKF_ARCHIVE[1]: postamble JGDAS_ENKF_ARCHIVE 1734113838 1

Additional information

No response

Do you have a proposed solution?

The following change to workflow/rocoto/gfs_tasks.py adds enkfgdas_echgres as a dependency to metatask enkfgdas_eamn

@@ -2898,6 +2898,8 @@ class GFSTasks(Tasks):
         deps = []
         dep_dict = {'type': 'metatask', 'name': f'{self.run}_epmn'}
         deps.append(rocoto.add_dependency(dep_dict))
+        dep_dict = {'type': 'task', 'name': 'enkfgdas_echgres'}
+        deps.append(rocoto.add_dependency(dep_dict))
         dependencies = rocoto.create_dependency(dep=deps)

         earcenvars = self.envars.copy()

When the revised gfs_tasks.py is used to generate the xml, we get the following dependencies for metatask enkfgdas_eamn

                <dependency>
                        <metataskdep metatask="enkfgdas_epmn"/>
                        <taskdep task="enkfgdas_echgres"/>
                </dependency>

[mingshichen-noaa]

Rahul, Thank you for assigning me the issue(#3165). Mingshi

…

On Tue, Dec 17, 2024 at 10:35 AM Rahul Mahajan ***@***.***> wrote: Assigned #3165 <#3165> to @mingshichen-noaa <https://github.com/mingshichen-noaa>. — Reply to this email directly, view it on GitHub <#3165 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALSJ4WAMZTNZMJR3GZ63GWL2GBAENAVCNFSM6AAAAABTSSSZG2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGY4DQMBRGU2TIMQ> . You are receiving this because you were assigned.Message ID: ***@***.***>

[aerorahul]

#3201 is likely a duplicate of this issue.
#3202 will resolve this issue.

[aerorahul]

The proposed solution in the issue description needs to be encapsulated in an <and> </and> condition to yield a valid rocoto dependency.