Switch Aerosol DA to use JCB and Jedi class #3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e bias correction files from tarball (NOAA-EMC#2862)
…on files using jedi class (NOAA-EMC#2862)
…ns analysis scripts (NOAA-EMC#2862)
|
marking this as ready to review as it will be ready once #3160 is resolved |
aerorahul
previously approved these changes
Dec 11, 2024
DavidNew-NOAA
previously approved these changes
Dec 11, 2024
RussTreadon-NOAA
dismissed stale reviews from DavidNew-NOAA and aerorahul
via
caa4500
|
Given approvals from @DavidNew-NOAA and @aerorahul , I will set up and run g-w CI for this PR on various machines once new fix files have been staged. @WalterKolczynski-NOAA and @KateFriedman-NOAA : g-w CI for this PR can not begin until the required fix files have been added to EIB staged fix file directories. See g-w issue #3160 for details. Note: We have no WCOSS2 dev access 12/16 through 12/20. If we are unable to run g-w CI for this PR before 12/16, we will need to wait until 12/21 or later for WCOSS2 testing. |
WalterKolczynski-NOAA
added
the
CI-Hera-Ready
emcbot
added
CI-Hera-Building
|
Hera C96C48_hybatmaerosnowDA failure g-w stream C96C48_hybatmaerosnowDA job enkfgdas_earc00 fails for 20211220 18Z due to File Since |
|
Hera C96C48_hybatmaerosnowDA failure follow up The following change to When the revised g-w issue #3165 open to report this bug. |
emcbot
added
CI-Hera-Running
|
CI Passed on Hera in Build# 1 |
4 tasks
|
g-w CI Install Dogwood Hera Orion All CI streams run on Dogwood, Hera, and Orion successfully completed all jobs with the following caveats |
RussTreadon-NOAA
approved these changes
Dec 14, 2024
|
@WalterKolczynski-NOAA : You do not need to set up g-w CI on WCOSS2. I ran on Dogwood (see results above). g-w CI has also been run on Orion. Do we need to run g-w CI on Hercules? |
WalterKolczynski-NOAA
merged commit bef3e0b
into
NOAA-EMC:develop
10 of 11 checks passed
sbanihash
pushed a commit
to sbanihash/global-workflow
that referenced
this pull request
Dec 14, 2024
This PR switches to using JCB for aerosol DA YAML generation + makes use of the Jedi class refactoring already done by @DavidNew-NOAA for the atmospheric JEDI-based DA. Resolves NOAA-EMC#3035 Note this PR is in draft for 2 reasons. 1) Need associated GDASApp PR to be opened and merged first and 2) requires some fix file updates. This will be coordinated with an issue and linked to this PR once @andytangborn is satisfied with a first-attempt at the fix files. --------- Co-authored-by: RussTreadon-NOAA <Russ.Treadon@noaa.gov> Co-authored-by: DavidNew-NOAA <david.new@noaa.gov>
|
Thank you @WalterKolczynski-NOAA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switches to using JCB for aerosol DA YAML generation + makes use of the Jedi class refactoring already done by @DavidNew-NOAA for the atmospheric JEDI-based DA.
Resolves #3035
Note this PR is in draft for 2 reasons. 1) Need associated GDASApp PR to be opened and merged first and 2) requires some fix file updates. This will be coordinated with an issue and linked to this PR once @andytangborn is satisfied with a first-attempt at the fix files.
Type of change
Change characteristics
How has this been tested?
Checklist