Feature/nicke sfcshp prepbufr #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasesposito
requested review from
emilyhcliu,
rmclaren,
ADCollard and
PraveenKumar-NOAA
|
Moved from draft to being reviewed @rmclaren @emilyhcliu @PraveenKumar-NOAA @ADCollard |
rmclaren
reviewed
Jan 15, 2025
dump/mapping/bufr_sfcshp_prepbufr.py
Outdated
| return description | ||
|
|
||
|
|
||
| def Compute_sequenceNumber(typ, t29): |
There was a problem hiding this comment.
function name does not follow convention
There was a problem hiding this comment.
Can you remind me where to find the convention?
There was a problem hiding this comment.
They are the python pep 8 conventions. https://peps.python.org/pep-0008/
There was a problem hiding this comment.
maybe def _compute_sequence_num(typ, t29)? Functions should be all lower case with words seperated by _.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds SFCSHP mapping yaml and encoder script to SPOC.
Takes care of Issue #8