Replaces pointers which are allocated with allocatables #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganganoaa
requested review from
thomas-robinson,
bensonr and
rem1776
as code owners
Do not check iarray2 and jarray2
Allocatables iarray and jarray are reverted to pointers.
rem1776
reviewed
May 3, 2023
| @@ -287,17 +287,17 @@ module xgrid_mod | |||
| !> Type to hold pointers for grid boxes | |||
| !> @ingroup xgrid_mod | |||
| type grid_box_type | |||
There was a problem hiding this comment.
This type is public and so are it's fields so we're gonna have to check the component's code to make sure these fields aren't used as pointers anywhere else besides internally (unless we want to make them private now but doubt that'll work).
This applies to xmap_type as well.
There was a problem hiding this comment.
Yes. You are right. If component codes are using them, this change certainly breaks something.
rem1776
reviewed
May 3, 2023
| @@ -2257,7 +2254,7 @@ end subroutine set_comm_get1_repro | |||
|
|
|||
| !####################################################################### | |||
| subroutine set_comm_get1(xmap) | |||
| type (xmap_type), intent(inout) :: xmap | |||
| type (xmap_type), intent(inout), target :: xmap | |||
| type (grid_type), pointer, save :: grid1 =>NULL() | |||
There was a problem hiding this comment.
guess we can't do much about these saved pointers right? might be less memory to save them as pointers anyway
There was a problem hiding this comment.
Pointers which are used as pointers should not be upgraded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates member pointers of grid_box_type, grid_type, comm_type, and xmap_type to allocatables, which were previously allocated, to handle better memory management and to prevent memory leaks. Some local pointers in subroutine load_xgrid() are also updated to allocatables for the same reason.
Fixes #1099
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.
Checklist:
make distcheckpasses