Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missed alias in libfms.F90 #1303

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add missed alias in libfms.F90 #1303

wants to merge 1 commit into from

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Jul 26, 2023

Description
adds 2 missed aliases in libFMS.F90 that slipped through with the last update.

Fixes #1288 (thanks Lauren for spotting these!)

How Has This Been Tested?
CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

thomas-robinson
thomas-robinson requested changes Jul 27, 2023
View reviewed changes
Copy link
Member

@thomas-robinson thomas-robinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs an update in the coupler

@laurenchilutti
Copy link
Contributor

This needs an update in the coupler

And also atmos_drivers

@rem1776 rem1776 mentioned this pull request Jul 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-robinson thomas-robinson thomas-robinson requested changes

@bensonr bensonr Awaiting requested review from bensonr bensonr is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2023.02-beta1: did not alias all functions in libFMS.F90
3 participants
@rem1776 @laurenchilutti @thomas-robinson