Simplify argument lists of subroutines in get_grid_version_mod
#1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 8, 2024 13:30
Remove compute domain indices from the argument lists of get_grid_version_1 and get_grid_version_2. Query compute domain indices from mpp_domains_mod at runtime and check the lower bounds of lon(:,:) and lat(:,:) arguments only if the _DEBUG macro is defined.
rem1776
approved these changes
May 30, 2024
rem1776
requested changes
Jun 12, 2024
|
|
||
| if (lbound(lat,1).ne.isc .or. lbound(lat,2).ne.jsc) then | ||
| call mpp_error(FATAL, "get_grid_version_1: Incorrect lower-bound dimensions of lat(isc:,jsc:)") | ||
| endif |
There was a problem hiding this comment.
@J-Lentz I noticed this was failing the GNU CI and looked into it a bit since it was coming from a test I wrote in the coupler subdirectory.
I was confused at first why this check kept failing since the passed in array had the right bounds, but after a little digging I realized that when passed in the array bounds get reset from whatever it may be to 1:<size of the array>.
I thought it was a bug but apparently that's how fortans supposed to work(?). I think we can either leave the lower bounds in the argument declaration so it can be checked, or we could just check the size here instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove compute domain indices from the argument lists of
get_grid_version_1andget_grid_version_2. Query compute domain indices frommpp_domains_modand check the lower bounds oflon(:,:)andlat(:,:)at runtime.Fixes #1371
How Has This Been Tested?
Builds on the AMD box with Intel compiler version 2024.1.0.
Checklist:
make distcheckpasses