Update and refactor fm_yaml_mod for new field_table format
#1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update fm_yaml_mod and the field_manager unit test for the new field_table format * Refactor and simplify fm_yaml_mod
J-Lentz
requested review from
bensonr,
thomas-robinson and
rem1776
as code owners
uramirez8707
previously approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Ran an AM5 c96 amip experiment with this PR + NOAA-GFDL/fms_yaml_tools#45 and turning the yaml format on. Results reproduced.
rem1776
requested changes
Jul 18, 2024
Add additional Doxygen syntax as per Ryan's review comments.
rem1776
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fm_yaml_modand the field_manager unit test for the new field_table formatfm_yaml_modHow Has This Been Tested?
Builds on the AMD box with Intel 2024.1 compiler; unit tests pass
Checklist:
make distcheckpasses