Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add debug flags to GNU CI and fix remaining failures #1579

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Aug 29, 2024

Description
Adds the debug flags from the mkmf template to the gnu CI and puts in fixes for two tests that were failing.

The time_interp_external2 changes just remove the hi_tmp_src_data temporary array that was added during mixed mode. I added the temp arrays to handle the intent(out) arguments in horiz_interp, but I don't think that argument specifically needed it. This change fixes a segfault occuring during one of the unit tests.

Fixes #1480 (maybe.. 🤞)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 requested a review from J-Lentz August 29, 2024 14:56
@rem1776 rem1776 marked this pull request as ready for review August 29, 2024 15:00
@rem1776 rem1776 marked this pull request as draft September 5, 2024 17:09
@rem1776 rem1776 marked this pull request as ready for review December 19, 2024 17:21
@rem1776 rem1776 changed the title add check flags to GNU CI and fix for data_override ci failures add debug flags to GNU CI and fix remaining failures Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_data_override sporadic failures in CI testing
1 participant