Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make define_blocks warning a note #1588

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

uramirez8707
Copy link
Contributor

@uramirez8707 uramirez8707 commented Sep 9, 2024

Description
Update so that only the root pe outouts the non uniform block size warning instead of every PE, which will make the stdout very large.

Fixes #1570

How Has This Been Tested?
CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

bensonr
bensonr previously approved these changes Sep 9, 2024
Copy link
Contributor

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update.

@rem1776
Copy link
Contributor

rem1776 commented Sep 10, 2024

It looks like this is hitting some kind of deadlock in the CI and is hanging during the openmp test for the new diag_manager. It only happens for the builds that have openmp turned off though.

https://github.com/NOAA-GFDL/FMS/actions/runs/10774360061/job/29934973086?pr=1588#step:7:6253

You should be able to reproduce it if you configure with --disable-openmp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make define_blocks warning a note
3 participants