Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes MAX_FIELDS_PER_FILE a namelist variable and allocates #750

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

thomas-robinson
Copy link
Member

Description
Changes the max_fields_per_file to a namelist variable, and allocated the fields with this value.

Fixes #747

How Has This Been Tested?
make run with intel

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@thomas-robinson thomas-robinson added this to the 2021.03 milestone May 20, 2021
@thomas-robinson thomas-robinson added this to In progress in 2021.03 via automation May 20, 2021
@thomas-robinson
Copy link
Member Author

@menzel-gfdl can you test this? Does it fulfill your request?

@rem1776 rem1776 removed this from In progress in 2021.03 Aug 5, 2021
@rem1776 rem1776 added this to In progress in 2021.04 via automation Aug 5, 2021
@rem1776 rem1776 removed this from In progress in 2021.04 Dec 23, 2021
@rem1776 rem1776 removed this from the 2021.03 milestone Jan 19, 2022
@thomas-robinson
Copy link
Member Author

@menzel-gfdl do you still want this?

Copy link
Contributor

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this change goes through, the error message in diag_manager/diag_util.F90 at line 1356ff needs to be updated.

@menzel-gfdl
Copy link
Collaborator

@thomas-robinson sorry I've been distracted by a lot of other projects. What are your thoughts? I proposed this because we kind of need 5d diagnostics (time, z, lat, lon, spectral dimension). Right now our only option is to create one variable per spectral dimension (band, wavenumber, gpoint, etc.), which as you can imagine leads to a very high number of diagnostics. Is there a better solution?

@thomas-robinson
Copy link
Member Author

@menzel-gfdl Yes there is a plan to support more dimensions in the diag manager rewrite. Although the target is September, there is no guarantee that 5D support will be working by then. If this PR solves your problem more immediately, then why not take it now. I don't think there is a reason why this shouldn't be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify max_fields_per_file via diag_manager namelist?
4 participants