Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding constants for SHiELD microphysics #17

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

oelbert
Copy link
Collaborator

@oelbert oelbert commented Feb 23, 2024

Description
the SHiELD model uses a different set of heat capacities (calculated at 0 C instead of 15 C) for calculations, and also introduces a new physics constants to use in calculations. This PR adds the new constants and a SHiELD constants version to select the correct heat capacities and derived constants.

How Has This Been Tested?
The SHiELD microphysics tests were run using this branch

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

fmalatino
fmalatino previously approved these changes Mar 5, 2024
@fmalatino fmalatino dismissed their stale review March 5, 2024 15:11

Was still in draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants