Global literal & temporary precision (for int & float) extended to gt4py and centralized #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging the 32-bit GEOS model we figured out that the precision was not necessarily pass down to
gt4py
properly. We've added a `GT4PY_LITERALndsl.dsl.__init__
import gt4py.cartesian.gtscript...
which is often the case WILL FAIL.The above points to a wider refactor: forward imports of
gtscript
tondsl
so user don't have to importgt4py
everHow Has This Been Tested?
Should be transparent to 64-bit cases and in GEOS test. That said, I expect many failures in
pyFV3
/Pace
because of the order of import.Checklist: