Preparing fre cmor to snack
#243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons. none checks, trying to generally allow this code to be more flexible. not currently working atm" This reverts commit 1a15d95.
ilaflott
added
documentation
This was
linked to
issues
Nov 15, 2024
ilaflott
added
bug
…assigned None and checked if corresponding cmor axis should bother to be assigned, instead of relying on dimenionality of the data
This was referenced Nov 15, 2024
…ordinate-depdendent data!
…mor module at all
…he code tries to create this. this is to avoid a warning from the CMOR module. it might be good to be able to do all of this so well that we could error on warning some day. ... oither than that, not much other than keeping certain other things around like CMOR behavior field values
…ug regarding numpy object usage- ians fault! needs from fresh eyes to find it
… i get it into cmor_mixer? i can now also start tackling ocean cases, which seem at least somewhat tractable now
… leave the python interpreter instance in the wrong directory
…o the cwd for the os gets set back to what it was before fre cmor run was called
…r exception reporting for try/except/finally call of rewrite_netcdf_file_var
…n native(tripolar)-grid ocean file case. the data one seeks is likely within the statics
…file to rewrite the ocean file when i get a chance... first, going to turn to olevel issues
This was referenced Dec 6, 2024
…t fields. rename prototype script for rewriting land file. miniscule edits to mixer itself
…a coordinate named depth_coord that has bounds. if i give cmor the values, it should do the rest
This was
linked to
issues
Dec 10, 2024
…nds it appropriately to the input file. but CMOR is not having it! what am i missing?
|
please feel free to begin reviewing the code. much will not change, but i need to fix a conflict and then clean a few things up. |
ceblanton
approved these changes
Dec 20, 2024
| @@ -75,7 +75,7 @@ background | |||
| ~~~~~~~~~~ | |||
|
|
|||
| The bulk of this routine is housed in ``fre/cmor/cmor_mixer.py``, which is a rewritten version of | |||
| Sergey Malyshev's original ``CMORcommander.py`` script, utilized during GFDL's CMIP6 publishing run. | |||
| Sergey Nikonov's original ``CMORcommander.py`` script, utilized during GFDL's CMIP6 publishing run. | |||
There was a problem hiding this comment.
CMORcommander was a prototype rewrite of fremetar, which GFDL used for CMIP6 publishing.
singhd789
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code QA:
this PR adds:
fre cmor lister, new tool for sifting through CMIP table json configurationsfre cmor listercli module callsallmorefrom 4->8 out of 9 cases covered CMORsnack: netCDF file format handling incmor_mixer#238docs/tools/cmor.rstHELPstringsCMOR_input_example.jsonunder test files to remove CMOR module warningcmor_mixer.pyfor reducing code repeat and making calls more consistent from line to linecreate_tmp_dirto squelch a toothless CMOR warning, with an overly optimistic eye towards using an error-on-warning setting for rigor someday.