Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#40 Update generic.cylc #41

Merged
merged 1 commit into from
Jan 23, 2025
Merged

#40 Update generic.cylc #41

merged 1 commit into from
Jan 23, 2025

Conversation

singhd789
Copy link
Contributor

The generic.cylc site file needed to be updated to create the output directories for tasks.

@singhd789 singhd789 requested a review from Ciheim January 10, 2025 16:28
ceblanton
ceblanton approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I'm a little philosophically opposed to having these non-site aspects (creating directories) in site files. Let's try to fix this as we go.

@singhd789
Copy link
Contributor Author

singhd789 commented Jan 17, 2025 •
edited
Loading

Looks fine. I'm a little philosophically opposed to having these non-site aspects (creating directories) in site files. Let's try to fix this as we go.

Ah ok. I mean I feel like just creating output directories could go in the actual flow.cylc. We'll have to change all the site files for that one eventually. For some tasks, like SPLIT-NETCDF (and rename-split-to-pp) that is the case already.

fre-workflows/flow.cylc

Line 729 in 0a9837a

pre-script = mkdir -p $outputDir

I'm not sure why only some tasks have the pre-script creating output dirs in the flow.cylc though.

@singhd789 singhd789 marked this pull request as ready for review January 17, 2025 16:35
Ciheim
Ciheim approved these changes Jan 23, 2025
View reviewed changes
Copy link

@Ciheim Ciheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but yeah I have to agree with the general sentiment towards directory creation in site files. Definitely something to think about later.

@singhd789 singhd789 merged commit 9483ee9 into main Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ciheim Ciheim Ciheim approved these changes

@ceblanton ceblanton ceblanton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@singhd789 @ceblanton @Ciheim