Updated container for Github Action and reusable workflow #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oelbert
approved these changes
Jun 18, 2024
| cd tests/main && mkdir -p input && cd input | ||
| python3 ../../../examples/generate_eta_files.py | ||
| cd ../../../ | ||
| - name: |
There was a problem hiding this comment.
Do we want to name this step?
There was a problem hiding this comment.
Hi Oliver, I'm so sorry! I decided to push in the reusable workflow changes to this PR, it might need your review again. 😇
xyuan
approved these changes
Jun 21, 2024
mlee03
changed the title
7 tasks
fmalatino
added a commit
that referenced
this pull request
Jan 6, 2025
* working baroclinic test case example (#81) * fixing dockerfile overriding netcdf, mpi4py, and numpy versions with mutually incompatible versions (#84) * Update notebooks for eta file creations (#85) * Update pace to use python 3.11.9 (#82) * Updated container for Github Action and reusable workflow (#87) * Updated container for Github Action and reusable workflow - Redo (#89) * Matching packages between main and develop branches and removal of outdated pull request template (#86) * Changed workflows to use python 3.11.7, added pytest-subtests to requirments_dev.txt * Updating constraints file * Updating Dockerfile to use 3.11-slim-bookworm base python image * reusable workflow CI - checkout corrrect repository (#90) * pace/tests/main/grid/test_eta.py moved to NDSL/tests/grid/test_eta.py (#92) * Updated README to include directions for generating eta files (#99) * Updated submodules to most recent versions as of 3 Jan 2025 15:35 EST * Updated c5 build script to match new methods --------- Co-authored-by: Oliver Elbert <oliver.elbert36@gmail.com> Co-authored-by: MiKyung Lee <58964324+mlee03@users.noreply.github.com> Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov> Co-authored-by: Xingqiu Yuan <xingqiu.yuan@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, the CI workflow is changed to run in this container. The new image is built from a base miniforge image. GNU compilers, netCDF and HDF5 libraries, and MPICH have been installed. The default python version is set to 3.11.7.
Tests with OpenMPI have been temporarily removed. The tests will be added with updates to the OpenMPI CI image.
In addition, reusable workflow capabilities have been added. Pace CI workflow can now be triggered by submodules.
Checklist: