Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModelExecRequestClient removed in #409, but still used in several places #467

Open
aaraney opened this issue Nov 2, 2023 · 2 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@aaraney
Copy link
Member

aaraney commented Nov 2, 2023

Failure: https://github.com/NOAA-OWP/DMOD/actions/runs/6734518026/job/18306532115?pr=463#step:11:41

Cause:

ModelExecRequestClient was removed in #409.
https://github.com/NOAA-OWP/DMOD/pull/409/files#diff-2192a18bf3f6c20ec42a0c4835df7df6da32273f4dba87d44a7c8cffd823d3b6L885

Effected Code:

from dmod.communication import DataServiceClient, ExternalRequestClient, ManagementAction, ModelExecRequestClient, \

class NgenRequestClient(ModelExecRequestClient[NGENRequest, NGENRequestResponse]):

class NgenCalRequestClient(ModelExecRequestClient[NgenCalibrationRequest, NgenCalibrationResponse]):

class JobRequestClient(ModelExecRequestClient):

class PostFormRequestClient(ModelExecRequestClient):

@aaraney aaraney added the bug Something isn't working label Nov 2, 2023
@aaraney
Copy link
Member Author

aaraney commented Jan 23, 2024

This looks like it will be resolved by #424.

@aaraney aaraney reopened this Apr 17, 2024
@aaraney
Copy link
Member Author

aaraney commented Apr 17, 2024

reopening. see #579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants