Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gh actions unit test #463

Merged

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Nov 2, 2023

  • Add build python matrix. Tests now run on python 3.8, 3.9, 3.10, and 3.11.
  • Add step to echo dependency versions. This is useful for debugging purposes.
  • Fix TLS certs email todo. Certs now use phony dmod_gh_action@fake.gov email address.

closes #457

@aaraney aaraney added enhancement New feature or request CI Issues related to the continuous integration testing. labels Nov 2, 2023
@aaraney
Copy link
Member Author

aaraney commented Nov 2, 2023

Nice! So we have failures in 3.8 because of the use of list[str] instead of typing.List[str] as a type hint. See #464 for more detail. Opening a PR now to fix this.

@aaraney
Copy link
Member Author

aaraney commented Nov 2, 2023

Opened #467 to track a failure due to removal of the ModelExecRequestClient class.

@aaraney aaraney force-pushed the gh_actions_python_build_matrix branch from 2debb42 to 76eb6b2 Compare November 2, 2023 16:41
@aaraney
Copy link
Member Author

aaraney commented Nov 2, 2023

Until NOAA-OWP/ngen-cal#64 is merged, pandas will need to be built in each gh action run (unless we add a cache) for 3.10 and 3.11 b.c. ngen-cal requires an older version of pandas that is not pre-built for these versions.

@aaraney
Copy link
Member Author

aaraney commented Jan 8, 2024

NOAA-OWP/ngen-cal#64 has been merged. This should be good to go now.

@robertbartel robertbartel merged commit fbcb699 into NOAA-OWP:master Jan 8, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues related to the continuous integration testing. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python version matrix in Actions workflow to test with different versions of Python
2 participants