Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign communication client types #409

Merged

Commits on Aug 9, 2023

  1. Redesign communication client types

    Redesigning and renaming abstraction, making it more focused on just the
    transport layer communication handling, rather than general service
    client behavior; also extending new type with a subtype that adds SSL
    context security.
    
    Making RequestClient concrete but generic.
    
    Add ConnectionContextClient as an abstract transport client than
    maintains a connection via an async managed context, and
    (re)implementing WebSocketClient using the new (secure) transport
    client with a context managed connection.
    
    Update specialized clients to extend RequestClient
    
    Fix ExternalClient with changes.
    robertbartel committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    8ccc9e7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    733ab9d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3ef01cf View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Configuration menu
    Copy the full SHA
    6b7c6f1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    52dfa9f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    072d086 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7362f99 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7e80278 View commit details
    Browse the repository at this point in the history
  6. Deprecating some RequestClient subclasses.

    Deprecating to help move away from service-specific types in a general
    library.
    robertbartel committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    7050ff6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f56bc98 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5b6d015 View commit details
    Browse the repository at this point in the history
  9. Update external request handlers for comms.

    Updating handlers to account for changes to communication package.
    robertbartel committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    fbf6fa0 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3f421ab View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Configuration menu
    Copy the full SHA
    2bc8fc3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f05a09c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    97548fa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b7ac988 View commit details
    Browse the repository at this point in the history
  5. Make WebSocketClient.build_endpoint_uri static.

    Making this a static method rather than a class method, as it doesn't
    need any class details.
    robertbartel committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    4be3cb1 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Put SSLContext directly in TransportLayerClient.

    Moving to top-level interface rather than having subtype for this.
    robertbartel committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    9e60aa0 View commit details
    Browse the repository at this point in the history
  2. Remove SSLSecuredTransportLayerClient.

    Removing redundant SSLSecuredTransportLayerClient subtype.
    robertbartel committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    abd58db View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Remove SSLSecuredTransportLayerClient from init.

    Removing redundant SSLSecuredTransportLayerClient from communication
    package __init__.py.
    robertbartel committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    da0c407 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b6160d View commit details
    Browse the repository at this point in the history
  3. Modify transport client to take URI components.

    Modifying TransportLayerClient to expect init params for (most of) the
    components of a URI, rather than the endpoint URI directly, and adding
    abstract property so that concrete types can implement this themselves
    (e.g., to control the specific protocol component used in the URI).
    robertbartel committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    549045f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2815193 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b3ec89e View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Configuration menu
    Copy the full SHA
    5d834f4 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Fix issues in client.py.

    Cleaning up TransportLayerClient __init__ to not pass var/keyword args
    to super (ABC), and removing abstract annotation from implemented
    method in WebSocketClient.
    robertbartel committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    3bc4cc6 View commit details
    Browse the repository at this point in the history
  2. Fix MockTransportLayerClient for unit tests.

    Fixing setup of scheduler client unit tests by adding implementation of
    this classmethod, declared as abstract in upstream superclass.
    robertbartel committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    828a1ea View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4dce763 View commit details
    Browse the repository at this point in the history
  4. Remove public client_ssl_context property.

    Removing public property in TransportLayerClient and replacing with use
    of private attribute.
    robertbartel committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    6d63be3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    583dbf3 View commit details
    Browse the repository at this point in the history
  6. Clarify that endpoint_host does not include protocol.

    Clarify that endpoint_host does not include protocol in docstring.
    
    Co-authored-by: Austin Raney <austin.raney@noaa.gov>
    robertbartel and aaraney authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    0aaf94a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a1bbb5e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    92e58e8 View commit details
    Browse the repository at this point in the history