Fix support for dependency version clauses for certain Python dependencies in Docker images #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing version clauses for certain dependency packages into build from .env configuration file via compose config.
Fixing version clause overrides for numpy, pandas, etc.
Updating with additional steps to (optionally) ensure that an explicit version clause, if provided on both sides, matches between .env and requirements.txt.
aaraney
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Looks good to me! The PR documentation made this really easy to review. Thanks as always, @robertbartel. Merge at will!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to be specific regarding certain Python dependencies - pandas for example. Additionally, a subset of such packages also each take a long time to install within our Docker images, leading us to have set up the images/stages to build wheels for these packages in advance and in isolated build stages.
There were Dockerfile
ARGelements set up to control the version clause of these packages if desired, but nothing in place to actually supply values to those. These changes address that by updating the stack compose config file to supply thoseARGs from the .env config.Also added are two other .env-controlled flags. One regards whether the aforementioned version clause
ARGs should override an explicit version clause within the project-level requirements.txt file, which is also used by the builds. The other regards whether a mismatch between .env-provided and requirements.txt-provided version clauses (when both are explicitly provided) should result in an error and stop the build.