Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying worker version #717

Merged
merged 15 commits into from
Sep 10, 2024

Conversation

robertbartel
Copy link
Contributor

@robertbartel robertbartel commented Sep 10, 2024

Allow jobs to be requested using a version of the worker other than the default (i.e., the latest tag).

Closes #662.

Changes

  • Added attribute to ngen and ngen-cal job requests for worker_version, that defaults to latest if not explicitly set
  • Modified determine_image_for_job function in Launcher class to use the new worker_version attribute in nested job request object of ngen and ngen-cal jobs, rather than always just latest
  • Updated CLI parsing for job exec to accept a --worker-version
  • Modified versions and dependency relationships as needed for involved services
  • Modified unit tests to match new deserialization structure

Testing

  1. Automated tests pass

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Adding worker_version to ExternalAbstractNgenRequest to be able to
specify a requested version of a job worker.
Updating Launcher determine_image_for_job to use supplied worker_version
value from originating request for ngen-type request objects, rather
than always defaulting to "latest."
Move scheduler package internal dependency on communication to 0.22.0.
Updating client package internal dependency on communication to 0.22.0.
Updating requestservice internal dependency on communication to 0.22.0.
Updating schedulerservice dependencies on communication to 0.22.0 and
scheduler to 0.14.0.
@robertbartel robertbartel added enhancement New feature or request maas MaaS Workstream labels Sep 10, 2024
Copy link
Member

@aaraney aaraney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaraney aaraney merged commit 2e192aa into NOAA-OWP:master Sep 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maas MaaS Workstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update client, requests, and services to support specifying worker image variant used for job
2 participants