Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added_assertions #12

Merged
merged 2 commits into from
Apr 1, 2024
Merged

added_assertions #12

merged 2 commits into from
Apr 1, 2024

Conversation

ajkhattak
Copy link
Contributor

PR adds a few checks to catch unrealistic values for soil parameters. No changes to the model's functionality.

…er minor changes to print useful error messages.
Copy link
Member

@aaraney aaraney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! Just one minor conditional that, I think, should be more broad.

src/soil_moisture_profile.cxx Outdated Show resolved Hide resolved
modified condition to check negative values as well.

Co-authored-by: Austin Raney <austin.raney@noaa.gov>
@ajkhattak
Copy link
Contributor Author

goood catch!

Copy link
Member

@aaraney aaraney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change, @ajkhattak!

@aaraney aaraney merged commit 532566a into main Apr 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants