Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: proc_attr_grabber.R #29

Merged
merged 6 commits into from
Nov 5, 2024
Merged

patch: proc_attr_grabber.R #29

merged 6 commits into from
Nov 5, 2024

Conversation

glitt13
Copy link
Collaborator

@glitt13 glitt13 commented Nov 1, 2024

Additions

  • Feat: Geospatial coordinate search for comid if the nwissite gage id returns NA but does return a coordinate.
  • A quick-and-dirty example script attr_gen_camels.R to download usgs nhdplus attribute data for all CAMELS locations, using local paths.
  • Integrate the check_attr_selection() function into standard processing by placing inside the newly created variable checker wrapper wrap_check_vars(). wrap_check_vars() also checks that the sublist inside Retr_Params$vars has appropriate names for attribute variable categories (e.g. usgs_vars and ha_vars).

Removals

Changes

  • Fix: Assign gage_id to data.frame in long format before concatenating using rbindlist.

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@glitt13 glitt13 requested a review from bolotinl November 1, 2024 19:21
Copy link
Collaborator

@bolotinl bolotinl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, all processing steps worked fine. Suggestion is to add to the wiki a step for creating the file data/input/user_data_std/juliemai-xSSA/nldi_feat_juliemai-xSSA_prediction.parquet (see backlog on the RaFts project board)

@glitt13 glitt13 merged commit b24ab4d into NOAA-OWP:main Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants