Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes random assortment of bugs #986

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fixes random assortment of bugs #986

merged 1 commit into from
Nov 20, 2024

Conversation

shawncrawley
Copy link
Collaborator

As discovered by the apocalyptic testing of the last deployment to TI

These changes fix the following errors:

{
  "Cause": "{\"errorMessage\":\"local variable 'v' referenced before assignment\",\"errorType\":\"UnboundLocalError\",\"requestId\":\"cecc439b-5943-4097-8500-7c1167659173\",\"stackTrace\":[\"  File \\\"/var/task/lambda_function.py\\\", line 126, in lambda_handler\\n    df_inundation = create_inundation_output(huc8, branch, stage_lookup, reference_time, input_variable, stage_ft_round_up=stage_ft_round_up)\\n\",\"  File \\\"/var/task/lambda_function.py\\\", line 463, in create_inundation_output\\n    raise e\\n\",\"  File \\\"/var/task/lambda_function.py\\\", line 458, in create_inundation_output\\n    inundation_windows = process(window)\\n\",\"  File \\\"/var/task/lambda_function.py\\\", line 430, in process\\n    mapping_ar[k] = v\\n\"]}",
  "Error": "UnboundLocalError",
  "ExecutionArn": "arn:aws:states:us-east-1:526904826677:execution:hv-vpp-ti-hand-fim-processing:sns_srf_hi_20241120T0000_201919_srf_48hr_max_inundation_hi_2",
  "Input": "{\"reference_time\":\"2024-11-20 00:00:00\",\"product\":\"srf_48hr_max_inundation_hi\",\"fim_config\":{\"name\":\"srf_48hr_max_inundation_hi\",\"flows_table\":\"cache.max_flows_srf_hi\",\"target_table\":\"fim_ingest.srf_48hr_max_inundation_hi\",\"fim_type\":\"hand\",\"postprocess\":{\"sql_file\":\"srf_48hr_max_inundation_hi\",\"target_table\":\"publish.srf_48hr_max_inundation_hi\"},\"sql_file\":\"srf_48hr_max_inundation_hi\"},\"huc_branches_to_process\":\"processing_outputs/srf_48hr_max_inundation_hi/srf_48hr_max_inundation_hi/workspace/20241120/00/hucs_to_process_2.csv\",\"AWS_STEP_FUNCTIONS_STARTED_BY_EXECUTION_ID\":\"arn:aws:states:us-east-1:526904826677:execution:hv-vpp-ti-viz-pipeline:sns_srf_hi_20241120T0000_201919\",\"data_prefix\":\"processing_outputs\",\"data_bucket\":\"hydrovis-ti-fim-us-east-1\"}",
  "InputDetails": {
    "Included": true
  },
  "Name": "sns_srf_hi_20241120T0000_201919_srf_48hr_max_inundation_hi_2",
  "RedriveCount": 0,
  "RedriveStatus": "REDRIVABLE",
  "StartDate": 1732130385006,
  "StateMachineArn": "arn:aws:states:us-east-1:526904826677:stateMachine:hv-vpp-ti-hand-fim-processing",
  "Status": "FAILED",
  "StopDate": 1732130386497
}
{
  "errorMessage": "Table derived.recurrence_flows_alaska does not exist.",
  "errorType": "RequiredTableNotUpdated",
  "requestId": "c567ab32-7d7c-47b1-8f08-d5e6e11a4ce2",
  "stackTrace": [
    "  File \"/var/task/lambda_function.py\", line 128, in lambda_handler\n    database(db_type=db_type).check_required_tables_updated(sql_path, sql_replace, reference_time, raise_if_false=True)\n",
    "  File \"/opt/python/viz_classes.py\", line 302, in check_required_tables_updated\n    raise RequiredTableNotUpdated(' '.join(issues_encountered))\n"
  ]
}

As discovered by the apocalyptic testing of the
last deployment to TI
@KatherinePowell-NOAA
Copy link
Contributor

Looks good to me - what I understand of the pipeline.

@shawncrawley shawncrawley merged commit c51f340 into ti Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants