utility script for making animations of forcing inputs #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilMiller
reviewed
Jan 2, 2024
Comment on lines
+74
to
+75
| crs = ccrs.epsg(epsg) | ||
| crs = ccrs.PlateCarree() |
There was a problem hiding this comment.
Which one is crs meant to be?
There was a problem hiding this comment.
The pyproj 5070 epsg code enforces a projection boundary that clips off the southern part of the CONUS domain, so for now using the PlateCarree. See comment on line 160. I'll clean this up a bit, just wanted to get it published in some form.
PhilMiller
reviewed
Jan 2, 2024
Comment on lines
+98
to
+99
| vmin = forcing['RAINRATE'].min().item() | ||
| vmin = 0.0009 |
There was a problem hiding this comment.
Another duplicate assignment
PhilMiller
reviewed
Jan 2, 2024
|
|
||
| forcing = forcing.set_index({"catchment ids":"catchment_ids"}).to_array().squeeze().drop_vars('variable') | ||
| #Get the catchment geopandas index, strip to int for xarray index | ||
| cat_ids = catchments['divide_id'].apply(lambda x: int(x.split("-")[1])) |
There was a problem hiding this comment.
Presumably true at the time of writing, but does the hydrofabric work guarantee unique numeric IDs of catchments across the various kinds that potentially prefix them?
Actually, are there currently or plans for catchment IDs prefixed other than cat-NNNN, like we have for nexuses?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script used to generate forcing animations for AGU 2023 fall meeting.