Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme.md: removed obsolete no-e option #843

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

JurgenZach-NOAA
Copy link
Contributor

The non-editable flag:
./compiler.sh no-e
is no longer necessary

(see #675 for details)

[Short description explaining the high-level reason for the pull request]

Additions

Removals

  • non-editable flag from compiler.sh

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

The non-editable flag:
./compiler.sh no-e
is no longer necessary 

(see #675 for details)
@JurgenZach-NOAA JurgenZach-NOAA merged commit ffad81d into master Sep 6, 2024
4 checks passed
@JurgenZach-NOAA JurgenZach-NOAA deleted the JurgenZach-NOAA-patch-1 branch September 6, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants