Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTX Code Release (PI-4): T-Route RnR Enhancements to PI-3 Deliverables through v2.2 Hydrofabric integration #850

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

taddyb
Copy link

@taddyb taddyb commented Dec 17, 2024

Today, Raytheon demo'd the FIM-Services capability to:

Make T-Route compatible with the current version of the Enterprise Hydrofabric. The requirement is verified through a demonstration of the deployment of Replace and Route using Terraform IaC

Thus, this PR builds on the changes introduced in #837 to:

  • Enhance Replace and Route through the introduction of an API
  • Allow the Replace and Route API to be configurable to work with different versions of the hydrofabric
    • this change supports v2.2 and v20.1

Additions

  • Additional API data for v2.2 of the hydrofabric
  • Changes to the HYFeaturesNetwork.py function to support v2.2 routing
  • A Notebook for testing v2.2 hydrofabric integration

Removals

Changes

  • Additions to include the Open Database License (ODbL) within the LICENSE to credit Lynker Spatial for supplying the Hydrofabric v2.2 dataset used in our testing.

Testing

  1. See test/LowerColorado_HYFeatures_v22/run_v22.ipynb to validate the v2.2 integration
  2. See test/api/README.md for information on testing the

Screenshots

image

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@taddyb
Copy link
Author

taddyb commented Dec 17, 2024

Note:

  • A SIGNIFICANT amount of the code introduced is data. If there is a better solution than to include forcing files where each hour is contained in one csv, I'm happy to participate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant