Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub 296 Fix for WresJobTest unit test failures. Properties added to setup. #310

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

HankHerr-NOAA
Copy link
Contributor

Description

Fix for unit test failures in WresJobTest. Required .p12 properties are now exported in setup.

Changes Made

Testing

Related Tickets

Checklists

Deployment Plan (For developer use)

How does the changes affect the product?

  • Feature addition
  • Bug fix
  • Database change

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • The feature branch you're submitting as a PR is up to date
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • No Placeholder code
  • Reviewers requested
  • Add yourself as an assignee in the PR

Merge Checklist (For Technical Lead use only)

  • If applicable, update README with major alterations

@HankHerr-NOAA HankHerr-NOAA merged commit 7c92b80 into master Sep 6, 2024
6 checks passed
@HankHerr-NOAA
Copy link
Contributor Author

Unit tests do not actually test the change made with this pull request due to a known problem with the unit tests not running wres-tasker or wres-worker tests.

@HankHerr-NOAA HankHerr-NOAA deleted the github_296 branch September 6, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swap to using environment variables for hard coded certs
1 participant