Merge pull request #1038 from daniel-thom/issue-1037

Fix serialization of System.frequency

src/base.jl

@@ -1407,7 +1407,16 @@ function IS.deserialize(
 
     # Read any field that is defined in System but optional for the constructors and not
     # already handled here.
-    handled = ("data", "units_settings", "bus_numbers", "internal", "data_format_version")
+    handled = (
+        "data",
+        "units_settings",
+        "bus_numbers",
+        "internal",
+        "data_format_version",
+        "metadata",
+        "name",
+        "description",
+    )
     parsed_kwargs = Dict{Symbol, Any}()
     for field in setdiff(keys(raw), handled)
         parsed_kwargs[Symbol(field)] = raw[field]
@@ -1429,7 +1438,14 @@ function IS.deserialize(
     name = get(metadata, "name", nothing)
     description = get(metadata, "description", nothing)
     internal = IS.deserialize(InfrastructureSystemsInternal, raw["internal"])
-    sys = System(data, units, internal; name = name, description = description, kwargs...)
+    sys = System(
+        data,
+        units,
+        internal;
+        name = name,
+        description = description,
+        parsed_kwargs...,
+    )
 
     if raw["data_format_version"] != DATA_FORMAT_VERSION
         pre_deserialize_conversion!(raw, sys)

test/test_serialization.jl

@@ -244,3 +244,26 @@ end
         ),
     )
 end
+
+@testset "Test serialization of System fields" begin
+    frequency = 50.0
+    name = "my_system"
+    description = "test"
+    sys = System(100; frequency = frequency, name = name, description = description)
+    bus = ACBus(nothing)
+    bus.name = "bus1"
+    bus.number = 1
+    # This prevents an error log message.
+    bus.bustype = ACBusTypes.REF
+    add_component!(sys, bus)
+    gen = ThermalStandard(nothing)
+    gen.bus = bus
+    gen.name = "gen1"
+    add_component!(sys, gen)
+
+    sys2, result = validate_serialization(sys)
+    @test result
+    @test sys2.frequency == frequency
+    @test sys2.metadata.name == name
+    @test sys2.metadata.description == description
+end