Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Partial] Update openstudio gems with new TBD and openstudio extensio… #4996

Merged
merged 5 commits into from
Oct 17, 2023
Merged

[Partial] Update openstudio gems with new TBD and openstudio extensio… #4996

merged 5 commits into from
Oct 17, 2023

Conversation

wenyikuang
Copy link
Collaborator

@wenyikuang wenyikuang commented Oct 11, 2023 •
edited by jmarrec
Loading

Pull request overview

  • Update openstudio gems with new TBD and openstudio extension gems.

Tested with local build, wait for ci build in openstudio-gem. Will update the PR with mac/Linux build after that.

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@wenyikuang wenyikuang self-assigned this Oct 11, 2023
@wenyikuang wenyikuang mentioned this pull request Oct 11, 2023
Merged
@jmarrec jmarrec added the Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. label Oct 14, 2023
jmarrec
jmarrec requested changes Oct 14, 2023
View reviewed changes
CMakeLists.txt Outdated
Comment on lines 837 to 838
set(OPENSTUDIO_GEMS_ZIP_FILENAME "openstudio3-gems-20231011-darwin_arm64.tar.gz") # TODO: redo
set(OPENSTUDIO_GEMS_ZIP_EXPECTED_MD5 "a98520ab33fa60aee008adec9ba7a999")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • TODO

CMakeLists.txt
set(OPENSTUDIO_GEMS_ZIP_FILENAME "openstudio3-gems-20230918-darwin.tar.gz")
set(OPENSTUDIO_GEMS_ZIP_EXPECTED_MD5 "71282202360c68cf9dd0f0d585d560f2")
set(OPENSTUDIO_GEMS_ZIP_FILENAME "openstudio3-gems-20231014-darwin.tar.gz")
set(OPENSTUDIO_GEMS_ZIP_EXPECTED_MD5 "d37f422e6d5792f2646de9f03ed31d94")
endif()
else()
if (ARCH MATCHES "arm64")
set(OPENSTUDIO_GEMS_ZIP_FILENAME "openstudio3-gems-20230918-linux_arm64.tar.gz")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo

@wenyikuang wenyikuang marked this pull request as draft October 17, 2023 17:42
@wenyikuang wenyikuang force-pushed the weny-update-tbd-gems branch from 999b918 to ebe1a1e Compare October 17, 2023 17:50
@ci-commercialbuildings ci-commercialbuildings marked this pull request as ready for review October 17, 2023 17:51
@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Oct 17, 2023 •
edited
Loading

CI Results for 66d19f4:

@wenyikuang
Copy link
Collaborator Author

wenyikuang commented Oct 17, 2023 •
edited
Loading

TODO: we may need update the CMakeList since I found for some reason the osx-incremental IS fetching the tar.gz from s3://openstudio-resources/dependencies/openstudio3-gems-20231017-darwin.tar.gz which is not synced from os-gem's CI upload destination. (It's a WRONG file, I don't even think that's 20231017, found since md5 unmatched.)

I upload the os3-gems-20231017-darwin.tar.gz mannually from local after downloading from s3 bucket from openstudio-sdk-dependencies/openstudio-gems/openstudio-gems-osx/PR-65/openstudio3-gems-20231017-darwin.tar.gz

@wenyikuang
Copy link
Collaborator Author

Since there is no cpp change, I think we could just skip the cpp related runners.

@wenyikuang wenyikuang merged commit e7ad0e0 into develop Oct 17, 2023
2 checks passed
@wenyikuang wenyikuang deleted the weny-update-tbd-gems branch October 17, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarrec jmarrec jmarrec requested changes

Assignees

@wenyikuang wenyikuang

Labels
component - Ruby bindings Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wenyikuang @ci-commercialbuildings @jmarrec