Skip to content

Commit

Permalink
Merge pull request #416 from rewiringamerica/develop
Browse files Browse the repository at this point in the history
Fix CI workflow for PRs from other forks
  • Loading branch information
nmerket authored Nov 17, 2023
2 parents d4e4a23 + fe28aca commit 60e79a2
Show file tree
Hide file tree
Showing 2 changed files with 46 additions and 5 deletions.
8 changes: 3 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,12 @@ jobs:
with:
name: coverage-report-html
path: buildstockbatch/coverage/htmlreport/
- name: Report coverage to PR
uses: 5monkeys/cobertura-action@v13
- name: Save Coverage Report XML
uses: actions/upload-artifact@v3
if: ${{ matrix.python-version == '3.11' }}
with:
name: coverage-report-xml
path: buildstockbatch/coverage/coverage.xml
repo_token: ${{ secrets.GITHUB_TOKEN }}
minimum_coverage: 33
fail_below_threshold: true
- name: Build documentation
if: ${{ matrix.python-version == '3.11' }}
run: |
Expand Down
43 changes: 43 additions & 0 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: Coverage report

on:
workflow_run:
workflows: ["BuildStockBatch Tests"]
types:
- completed

jobs:
coverage:
name: Post coverage report to PR
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.event == 'pull_request' }}

steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
ref: ${{ github.event.workflow_run.head_commit.id }}

- name: Download Coverage Artifacts
uses: Legit-Labs/action-download-artifact@v2
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
workflow: ${{ github.event.workflow_run.workflow_id }}
workflow_conclusion: success
commit: ${{ github.event.workflow_run.head_commit.id }}
name: coverage-report-xml
path: buildstockbatch/coverage

# This step is here instead of in ci.yml because PRs from other forks
# do not have write permission to the PR during a pull_request action.
# More information:
# https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
# Example to follow:
# https://github.com/5monkeys/cobertura-action/tree/master/.github/workflows
- name: Report coverage to PR
uses: 5monkeys/cobertura-action@v13
with:
path: buildstockbatch/coverage/coverage.xml
repo_token: ${{ secrets.GITHUB_TOKEN }}
minimum_coverage: 33
fail_below_threshold: true

0 comments on commit 60e79a2

Please sign in to comment.