Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing weather files download on Eagle #398

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Fixing weather files download on Eagle #398

merged 2 commits into from
Oct 13, 2023

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented Oct 10, 2023

Fixes #390.

@nmerket nmerket self-assigned this Oct 10, 2023
@nmerket nmerket requested a review from whiphi92 October 10, 2023 21:41
@nmerket
Copy link
Member Author

nmerket commented Oct 10, 2023

@whiphi92 It was the RAM disk thing. I changed it to put the temporary file in the /tmp/scratch directory if it exists, which has like 1TB of space. Can you give this a spin and let me know if it works for you? It seems to be working for me.

@nmerket nmerket added this to the v2023.10.0 milestone Oct 10, 2023
@github-actions
Copy link

github-actions bot commented Oct 10, 2023

File Coverage
All files 84%
base.py 89%
eagle.py 79%
exc.py 57%
local.py 50%
postprocessing.py 84%
utils.py 96%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 84%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against 423c073

@nmerket
Copy link
Member Author

nmerket commented Oct 12, 2023

@whiphi92 is getting the following error, I think in one of the job.out-* files on this one

Traceback (most recent call last):
  File "/shared-projects/buildstock/envs/pwhite_weather_tempfile_test/lib/python3.10/site-packages/buildstockbatch/utils.py", line 107, in run_with_error_capture
    return func(*args, **kwargs)
  File "/shared-projects/buildstock/envs/pwhite_weather_tempfile_test/lib/python3.10/site-packages/buildstockbatch/eagle.py", line 830, in main
    batch.run_job_batch(job_array_number)
  File "/shared-projects/buildstock/envs/pwhite_weather_tempfile_test/lib/python3.10/site-packages/buildstockbatch/eagle.py", line 236, in run_job_batch
    self.clear_and_copy_dir(
  File "/shared-projects/buildstock/envs/pwhite_weather_tempfile_test/lib/python3.10/site-packages/buildstockbatch/eagle.py", line 129, in clear_and_copy_dir
    shutil.copytree(src, dst)
  File "/shared-projects/buildstock/envs/pwhite_weather_tempfile_test/lib/python3.10/shutil.py", line 559, in copytree
    return _copytree(entries=entries, src=src, dst=dst, symlinks=symlinks,
  File "/shared-projects/buildstock/envs/pwhite_weather_tempfile_test/lib/python3.10/shutil.py", line 457, in _copytree
    os.makedirs(dst, exist_ok=dirs_exist_ok)
  File "/shared-projects/buildstock/envs/pwhite_weather_tempfile_test/lib/python3.10/os.py", line 225, in makedirs
    mkdir(name, mode)
FileExistsError: [Errno 17] File exists: '/tmp/scratch/buildstock/resources/hpxml-measures'

So far I have been unable to duplicate it.

@nmerket
Copy link
Member Author

nmerket commented Oct 13, 2023

I successfully ran a test run last night and it worked for me.

@afontani afontani self-requested a review October 13, 2023 20:36
Copy link
Collaborator

@afontani afontani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it on Eagle. Everything ran successfully.

@nmerket
Copy link
Member Author

nmerket commented Oct 13, 2023

It worked for me too. I think we can chalk this up to some Eagle weirdness and go ahead and merge it.

@nmerket nmerket merged commit d0dd684 into develop Oct 13, 2023
6 checks passed
@nmerket nmerket deleted the weather_tempfiles branch October 13, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using default TMY weather URL receiving error-- OSError: [Errno 28] No space left on device
2 participants