Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove always-added reporting measure from Comstock #399

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

eringold
Copy link
Collaborator

@eringold eringold commented Oct 12, 2023

SimulationOutputReport was being added to the comstock workflow by default, as well as when specified in the yml. This removes the default addition: SimulationOutputReport must be specified in the yml to be included in the workflow.

Eyeballing from my recent profiling of a 10k run shows the second instance of SimulationOutputReport taking roughly 10% of the total workflow runtime.

@github-actions
Copy link

github-actions bot commented Oct 12, 2023

File Coverage
All files 84%
base.py 89%
eagle.py 79%
exc.py 57%
local.py 50%
postprocessing.py 84%
utils.py 96%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 84%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against 9cc96c5

Copy link
Member

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Could you put something in the changelog for this?

@eringold
Copy link
Collaborator Author

Thanks @nmerket, I've updated the changelog.

@nmerket nmerket merged commit a645bb5 into develop Oct 13, 2023
6 checks passed
@nmerket nmerket deleted the fix/comstock_repeat_simoutreport branch October 13, 2023 15:24
@nmerket nmerket added this to the v2023.10.0 milestone Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants